[libc-commits] [libc] [libc] Implement vasprintf and asprintf (PR #98824)

[via libc-commits]

zeroomega wrote:

> > Hi, This patch broke the armv6m runtime build with libc. We are seeing cmake config errors after this patch landed:
> > ```
> > CMake Error at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:5 (get_target_property):
> >   get_target_property() called with non-existent target
> >   "libc.src.stdio.printf_core.vasprintf_internal".
> > Call Stack (most recent call first):
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:36 (collect_object_file_deps)
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:63 (collect_object_file_deps)
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:142 (get_all_object_file_deps)
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/lib/CMakeLists.txt:22 (add_entrypoint_library)
> > CMake Error at /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:5 (get_target_property):
> >   get_target_property() called with non-existent target
> >   "libc.src.stdio.printf_core.vasprintf_internal".
> > Call Stack (most recent call first):
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:36 (collect_object_file_deps)
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:63 (collect_object_file_deps)
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/cmake/modules/LLVMLibCLibraryRules.cmake:142 (get_all_object_file_deps)
> >   /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libc/lib/CMakeLists.txt:22 (add_entrypoint_library)
> > -- Using libc++ testing configuration: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/libcxx/test/configs/llvm-libc++-static.cfg.in
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > Affected build task: https://lab.llvm.org/buildbot/#/builders/11/builds/2745 Could you revert the change and reland it after fixing it please?
> 
> Let me know if [97f723b](https://github.com/llvm/llvm-project/commit/97f723bab0f48aca1416b9f946037b39b11d50e9) fixes it.

That patch fixed the issue. Thanks.

https://github.com/llvm/llvm-project/pull/98824