[libc-commits] [libc] [libc] added cos function fuzzing test (PR #101556)

[via libc-commits]

https://github.com/RoseZhang03 updated https://github.com/llvm/llvm-project/pull/101556

>From 9798abe445b750be9617a03ac7da180f78546105 Mon Sep 17 00:00:00 2001
From: Rose Zhang <rosezhang at google.com>
Date: Thu, 1 Aug 2024 20:26:34 +0000
Subject: [PATCH 1/2] [libc] added cos function fuzzing test

---
 libc/fuzzing/math/CMakeLists.txt |  9 +++++++
 libc/fuzzing/math/cos_fuzz.cpp   | 40 ++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)
 create mode 100644 libc/fuzzing/math/cos_fuzz.cpp

diff --git a/libc/fuzzing/math/CMakeLists.txt b/libc/fuzzing/math/CMakeLists.txt
index ad163cc53eae3..7faf8fd53c849 100644
--- a/libc/fuzzing/math/CMakeLists.txt
+++ b/libc/fuzzing/math/CMakeLists.txt
@@ -70,3 +70,12 @@ add_libc_fuzzer(
   DEPENDS
     libc.src.math.sin
 )
+
+add_libc_fuzzer(
+  cos_fuzz
+  NEED_MPFR
+  SRCS
+    cos_fuzz.cpp
+  DEPENDS
+    libc.src.math.cos
+)
diff --git a/libc/fuzzing/math/cos_fuzz.cpp b/libc/fuzzing/math/cos_fuzz.cpp
new file mode 100644
index 0000000000000..f961a17e7f203
--- /dev/null
+++ b/libc/fuzzing/math/cos_fuzz.cpp
@@ -0,0 +1,40 @@
+//===-- cos_fuzz.cpp ----------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// Fuzzing test for llvm-libc cos implementation.
+///
+//===----------------------------------------------------------------------===//
+
+#include "src/math/cos.h"
+#include <cmath>
+#include <mpfr.h>
+
+extern "C" int LLVMFuzzerTestOneInput(const double x) {
+  // remove NaN and inf as preconditions
+  if (std::isnan(x))
+    return 0;
+  if (std::isinf(x))
+    return 0;
+  // signed zeros already tested in unit tests
+  if (std::signbit(x) && x == 0.0)
+    return 0;
+  mpfr_t input;
+  mpfr_init2(input, 53);
+  mpfr_set_d(input, x, MPFR_RNDN);
+  int output = mpfr_cos(input, input, MPFR_RNDN);
+  mpfr_subnormalize(input, output, MPFR_RNDN);
+  double to_compare = mpfr_get_d(input, MPFR_RNDN);
+
+  double result = LIBC_NAMESPACE::cos(x);
+
+  if (result != to_compare)
+    __builtin_trap();
+
+  mpfr_clear(input);
+  return 0;
+}

>From 80094b2c4cb26c9c0e0b112100c2d507614bb678 Mon Sep 17 00:00:00 2001
From: Rose Zhang <rosezhang at google.com>
Date: Thu, 1 Aug 2024 21:37:02 +0000
Subject: [PATCH 2/2] use libc math.h instead of standard library

---
 libc/fuzzing/math/cos_fuzz.cpp | 8 ++++----
 libc/fuzzing/math/sin_fuzz.cpp | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/libc/fuzzing/math/cos_fuzz.cpp b/libc/fuzzing/math/cos_fuzz.cpp
index f961a17e7f203..e04152e373590 100644
--- a/libc/fuzzing/math/cos_fuzz.cpp
+++ b/libc/fuzzing/math/cos_fuzz.cpp
@@ -11,17 +11,17 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/math/cos.h"
-#include <cmath>
+#include <math.h>>
 #include <mpfr.h>
 
 extern "C" int LLVMFuzzerTestOneInput(const double x) {
   // remove NaN and inf as preconditions
-  if (std::isnan(x))
+  if (isnan(x))
     return 0;
-  if (std::isinf(x))
+  if (isinf(x))
     return 0;
   // signed zeros already tested in unit tests
-  if (std::signbit(x) && x == 0.0)
+  if (signbit(x) && x == 0.0)
     return 0;
   mpfr_t input;
   mpfr_init2(input, 53);
diff --git a/libc/fuzzing/math/sin_fuzz.cpp b/libc/fuzzing/math/sin_fuzz.cpp
index 1e607d461978d..0293afb062839 100644
--- a/libc/fuzzing/math/sin_fuzz.cpp
+++ b/libc/fuzzing/math/sin_fuzz.cpp
@@ -11,17 +11,17 @@
 //===----------------------------------------------------------------------===//
 
 #include "src/math/sin.h"
-#include <cmath>
+#include <math.h>
 #include <mpfr.h>
 
 extern "C" int LLVMFuzzerTestOneInput(const double x) {
   // remove NaN and inf as preconditions
-  if (std::isnan(x))
+  if (isnan(x))
     return 0;
-  if (std::isinf(x))
+  if (isinf(x))
     return 0;
   // signed zeros already tested in unit tests
-  if (std::signbit(x) && x == 0.0)
+  if (signbit(x) && x == 0.0)
     return 0;
   mpfr_t input;
   mpfr_init2(input, 53);