[libc-commits] [libc] [libc][math] adds more FP test macros and fixes bug in `{EXPECT, ASSERT}_FP_EXCEPTION` (PR #88816)

via libc-commits libc-commits at lists.llvm.org
Mon Apr 29 14:46:19 PDT 2024


lntue wrote:

> Yeah, I think there is a lot of overlap, and the #89658 is much nicer. The changes in this PR to `test/src/math/*` and the change from `ASSERT_GE` -> `EXPECT_GE` and `ASSERT_EQ` -> `EXPECT_EQ` are still relevant. @lntue what do you think about the following: I will drop the rest of the macros and leave this PR as changes to `{EXPECT,ASSERT}_FP_EXCEPTION`, then add another PR to replace the dropped macros with `FEnvSafeTest` style wrappers. Then, onto addressing #88819 and #88768, #88769, #88770, #88771, #88772.

SGTM.

https://github.com/llvm/llvm-project/pull/88816


More information about the libc-commits mailing list