https://github.com/michaelrj-google commented: This looks good from a code style perspective, but final math review will probably have to wait until @lntue is back. Thanks for making this patch! https://github.com/llvm/llvm-project/pull/87992