[libc-commits] [libc] [libc][setjmp][x86] implement setjmp in terms of out of line asm (PR #88157)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Apr 22 14:25:09 PDT 2024


nickdesaulniers wrote:

Meta comment, the larger this PR gets, the more the naked fn attr looks attractive.
https://github.com/llvm/llvm-project/pull/88054

That said, there is a fair amount of one time cost for adding some functionality here that will be reusable for other asm implementations in the future.  Not sure yet how I feel yet about which is "better." But I think completing this impl correctly will give everyone a better sense for the different approaches; and I am happy to discard whichever approaches are unsuitable. Sometimes having the multiple implementations on hand better forms the discussion.

https://github.com/llvm/llvm-project/pull/88157


More information about the libc-commits mailing list