[libc-commits] [libc] [libc] set cmake dependencies for condattr test (PR #89103)

via libc-commits libc-commits at lists.llvm.org
Wed Apr 17 10:21:55 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

<details>
<summary>Changes</summary>

The entrypoints are not yet exposed on non-x86.  Express this dependency to
unbreak post submit.

Fixes #<!-- -->88987


---
Full diff: https://github.com/llvm/llvm-project/pull/89103.diff


2 Files Affected:

- (modified) libc/src/pthread/pthread_condattr_destroy.cpp (+1-1) 
- (modified) libc/test/src/pthread/CMakeLists.txt (+6) 


``````````diff
diff --git a/libc/src/pthread/pthread_condattr_destroy.cpp b/libc/src/pthread/pthread_condattr_destroy.cpp
index 45cc011a4a92d8..4fb3ea6f502e03 100644
--- a/libc/src/pthread/pthread_condattr_destroy.cpp
+++ b/libc/src/pthread/pthread_condattr_destroy.cpp
@@ -14,7 +14,7 @@
 
 namespace LIBC_NAMESPACE {
 
-LLVM_LIBC_FUNCTION(int, pthread_condattr_destroy, (pthread_condattr_t * attr)) {
+LLVM_LIBC_FUNCTION(int, pthread_condattr_destroy, (pthread_condattr_t * attr [[gnu::unused]])) {
   // Initializing a pthread_condattr_t acquires no resources, so this is a
   // no-op.
   return 0;
diff --git a/libc/test/src/pthread/CMakeLists.txt b/libc/test/src/pthread/CMakeLists.txt
index 46f38422a53745..51954a5babd2c5 100644
--- a/libc/test/src/pthread/CMakeLists.txt
+++ b/libc/test/src/pthread/CMakeLists.txt
@@ -50,4 +50,10 @@ add_libc_unittest(
     libc.include.errno
     libc.include.pthread
     libc.include.time
+    libc.src.pthread.pthread_condattr_destroy
+    libc.src.pthread.pthread_condattr_getclock
+    libc.src.pthread.pthread_condattr_getpshared
+    libc.src.pthread.pthread_condattr_init
+    libc.src.pthread.pthread_condattr_setclock
+    libc.src.pthread.pthread_condattr_setpshared
   )

``````````

</details>


https://github.com/llvm/llvm-project/pull/89103


More information about the libc-commits mailing list