[libc-commits] [libc] 70e189f - [libc] fixup ftello test (#87282)

[via libc-commits]

Author: Nick Desaulniers
Date: 2024-04-01T14:13:56-07:00
New Revision: 70e189fbc96909d3841dd2bca4a2909345cd826f

URL: https://github.com/llvm/llvm-project/commit/70e189fbc96909d3841dd2bca4a2909345cd826f
DIFF: https://github.com/llvm/llvm-project/commit/70e189fbc96909d3841dd2bca4a2909345cd826f.diff

LOG: [libc] fixup ftello test (#87282)

Use a seek offset that fits within the file size.

This was missed in presubmit because the FILE based stdio tests aren't
run in
overlay mode; fullbuild is not tested in presubmit.

WRITE_SIZE == 11, so using a value of 42 for offseto would cause the
expression
`WRITE_SIZE - offseto` to evaluate to -31 as an unsigned 64b integer
(18446744073709551585ULL).

Fixes #86928

Added: 
    

Modified: 
    libc/test/src/stdio/ftell_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/test/src/stdio/ftell_test.cpp b/libc/test/src/stdio/ftell_test.cpp
index 68a969ed0c30dd..62745e2194be6d 100644
--- a/libc/test/src/stdio/ftell_test.cpp
+++ b/libc/test/src/stdio/ftell_test.cpp
@@ -39,7 +39,7 @@ class LlvmLibcFTellTest : public LIBC_NAMESPACE::testing::Test {
     // still return the correct effective offset.
     ASSERT_EQ(size_t(LIBC_NAMESPACE::ftell(file)), WRITE_SIZE);
 
-    off_t offseto = 42;
+    off_t offseto = 5;
     ASSERT_EQ(0, LIBC_NAMESPACE::fseeko(file, offseto, SEEK_SET));
     ASSERT_EQ(LIBC_NAMESPACE::ftello(file), offseto);
     ASSERT_EQ(0, LIBC_NAMESPACE::fseeko(file, -offseto, SEEK_END));