[libc-commits] [libc] [libc] fixup missing include for fullbuild (PR #87266)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Apr 1 10:43:13 PDT 2024


nickdesaulniers wrote:

Looking at [libc/spec/posix.td](https://github.com/llvm/llvm-project/blob/main/libc/spec/posix.td), we have `OffTType` for the `off_t` definition. It gets re-exported for:
- sys/mman.h
- unistd.h
- sys/stat.h
- sys/types.h

`man off_t` says:

> SYNOPSIS
>       #include <sys/types.h>
> The  following  headers  also  provide  off_t:
 * <aio.h>
 * <fcntl.h>
 * <stdio.h>
 * <sys/mman.h>
 * <sys/stat.h>
 * <unistd.h>

So, we're missing re-exporting it from:
- aio.h
- fcntl.h
- stdio.h (what led to this bug; we should fix that then revert my change here in the same commit)

We don't implement aio.h yet, so instead we should:
1. add `OffTType` to fcntl.h and stdio.h 's Macro lists in libc/spec/posix.td
2. undo changes I made here

@Sh0g0-1758 care to send a patch for that, or shall I?

https://github.com/llvm/llvm-project/pull/87266


More information about the libc-commits mailing list