[libc-commits] [PATCH] D137451: [CMake] Use LLVM_RUNTIME_TARGET in runtimes

[Martin Storsjö via Phabricator via libc-commits]

mstorsjo accepted this revision.
mstorsjo added a comment.

In D137451#4651752 <https://reviews.llvm.org/D137451#4651752>, @phosek wrote:

> In D137451#4651440 <https://reviews.llvm.org/D137451#4651440>, @mstorsjo wrote:
>
>> That seems reasonable to me. Would the next steps after that be to do an actual deprecation cycle - warning users if they're setting the old variable name and making `LLVM_RUNTIME_TARGET` a cache variable as well? And then after the next release (or later?), remove handling of the old variable name here?
>
> That was my plan assuming we don't want to keep support for `LLVM_DEFAULT_TARGET_TRIPLE` which would be my preference.

That sounds very good to me, if given a reasonable deprecation cycle (one major release with both setups working, with warnings suggesting moving from old to new).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137451/new/

https://reviews.llvm.org/D137451