[libc-commits] [libc] [libc] Scan the ports more fairly in the RPC server (PR #66680)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Sun Sep 24 15:42:43 PDT 2023


================
@@ -560,9 +562,9 @@ template <uint16_t opcode> LIBC_INLINE Client::Port Client::open() {
 template <uint32_t lane_size>
 [[clang::convergent]] LIBC_INLINE
     cpp::optional<typename Server<lane_size>::Port>
-    Server<lane_size>::try_open() {
+    Server<lane_size>::try_open(uint32_t start) {
   // Perform a naive linear scan for a port that has a pending request.
-  for (uint32_t index = 0; index < process.port_count; ++index) {
+  for (uint32_t index = start; index < process.port_count; ++index) {
----------------
jhuber6 wrote:

> For now I don't see what the benefit would be to return to the caller of handle_server, just to let them call it again.

My main concern was if we had the user's thread running the server it could potentially be blocked for a long time if it keeps picking up some other kernel's work. I could instead do the method where we start at the last known index, but  always check N ports.

https://github.com/llvm/llvm-project/pull/66680


More information about the libc-commits mailing list