[libc-commits] [libc] [libc] Scan the ports more fairly in the RPC server (PR #66680)

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Sat Sep 23 12:03:21 PDT 2023


================
@@ -560,9 +562,9 @@ template <uint16_t opcode> LIBC_INLINE Client::Port Client::open() {
 template <uint32_t lane_size>
 [[clang::convergent]] LIBC_INLINE
     cpp::optional<typename Server<lane_size>::Port>
-    Server<lane_size>::try_open() {
+    Server<lane_size>::try_open(uint32_t start) {
   // Perform a naive linear scan for a port that has a pending request.
-  for (uint32_t index = 0; index < process.port_count; ++index) {
+  for (uint32_t index = start; index < process.port_count; ++index) {
----------------
jhuber6 wrote:

That's what I'm intending with this logic. When the user calls `handle_server` it will guaruntee that all `1 through N` ports will be checked. If it finds work on a port, it handles it, then picks back up where it left off. If we make each check go `1 through N` modulo the port size then we'll be in the same situation where we don't know whether or not `handle_server` will run a bounded number of times.

https://github.com/llvm/llvm-project/pull/66680


More information about the libc-commits mailing list