[libc-commits] [libc] [libc] Add ${CMAKE_CROSSCOMPILING_EMULATOR} to custom test cmdlines (PR #66565)

[Mikhail R. Gadelha via libc-commits]

================
@@ -561,7 +561,7 @@ function(add_integration_test test_name)
   # to expand the list (by including the option COMMAND_EXPAND_LISTS). This
   # makes `add_custom_target` construct the correct command and execute it.
   set(test_cmd
-      ${INTEGRATION_TEST_ENV}
+      ${CMAKE_CROSSCOMPILING_EMULATOR} ${INTEGRATION_TEST_ENV}
----------------
mikhailramalho wrote:

That sounds like a good idea, but how do you handle env variables in these cases? 

Currently, the script I wrote expects `<env variables> <full path to binary> <args>` to work properly... We need the full path to the binary to scp any test data present in the binary directory; we then copy the binary to a temp dir in the qemu-system and call `ssh foo at bar <env variables> ~/<temp dir>/<binary> <args>`.

(I should probably upload the script I'm using somewhere).

https://github.com/llvm/llvm-project/pull/66565