[libc-commits] [libc] [libc] Specify path for making include/ subdirs (PR #66589)

Jeff Bailey via libc-commits libc-commits at lists.llvm.org
Sun Sep 17 09:12:33 PDT 2023


https://github.com/kaladron updated https://github.com/llvm/llvm-project/pull/66589

>From 268d775744e26d0866ba41858af90e9cb1820601 Mon Sep 17 00:00:00 2001
From: Jeff Bailey <jbailey at raspberryginger.com>
Date: Sun, 17 Sep 2023 00:16:13 +0000
Subject: [PATCH] [libc] Specify path for making include/ subdirs

When doing a clean build from vscode, it makes the subdirectories in the
source tree rather than in the build folder.  Elsehwere in LLVM, they
prefix the MAKE_DIRECTORY calls, so this appears to be the correct
approach.

Tested:
Build within vscode
Commandline build with:
cmake ../llvm -DLLVM_ENABLE_PROJECTS="libc" -DCMAKE_BUILD_TYPE=Debug \
-DLLVM_LIBC_FULL_BUILD=true -DCMAKE_C_COMPILER=clang \
-DCMAKE_CXX_COMPILER=clang++
cmke --build . --target libc

(Note that this is Makefile build, not ninja)
---
 libc/include/CMakeLists.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libc/include/CMakeLists.txt b/libc/include/CMakeLists.txt
index 2e57275e10bc4cf..fd2cb9351419ca8 100644
--- a/libc/include/CMakeLists.txt
+++ b/libc/include/CMakeLists.txt
@@ -78,7 +78,7 @@ add_gen_header(
 )
 
 # TODO: This should be conditional on POSIX networking being included.
-file(MAKE_DIRECTORY "arpa")
+file(MAKE_DIRECTORY ${LIBC_INCLUDE_DIR}/arpa)
 
 add_gen_header(
   arpa_inet
@@ -280,7 +280,7 @@ add_gen_header(
 # TODO: Not all platforms will have a include/sys directory. Add the sys
 # directory and the targets for sys/*.h files conditional to the OS requiring
 # them.
-file(MAKE_DIRECTORY "sys")
+file(MAKE_DIRECTORY ${LIBC_INCLUDE_DIR}/sys)
 
 add_gen_header(
   sys_auxv
@@ -497,7 +497,7 @@ add_gen_header(
 )
 
 if(LIBC_TARGET_ARCHITECTURE_IS_GPU)
-  file(MAKE_DIRECTORY "gpu")
+  file(MAKE_DIRECTORY ${LIBC_INCLUDE_DIR}/gpu)
 
   add_gen_header(
     gpu_rpc



More information about the libc-commits mailing list