[libc-commits] [libc] [libc] Specify path for making include/ subdirs (PR #66589)

via libc-commits libc-commits at lists.llvm.org
Sat Sep 16 17:24:51 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libc

<details>
<summary>Changes</summary>

When doing a clean build from vscode, it makes the subdirectories in the source tree rather than in the build folder.  Elsehwere in LLVM, they prefix the MAKE_DIRECTORY calls, so this appears to be the correct approach.
---
Full diff: https://github.com/llvm/llvm-project/pull/66589.diff


1 Files Affected:

- (modified) libc/include/CMakeLists.txt (+3-3) 


``````````diff
diff --git a/libc/include/CMakeLists.txt b/libc/include/CMakeLists.txt
index 2e57275e10bc4cf..06a342d28221561 100644
--- a/libc/include/CMakeLists.txt
+++ b/libc/include/CMakeLists.txt
@@ -78,7 +78,7 @@ add_gen_header(
 )
 
 # TODO: This should be conditional on POSIX networking being included.
-file(MAKE_DIRECTORY "arpa")
+file(MAKE_DIRECTORY ${LIBC_INCLUDE_DIR}/"arpa")
 
 add_gen_header(
   arpa_inet
@@ -280,7 +280,7 @@ add_gen_header(
 # TODO: Not all platforms will have a include/sys directory. Add the sys
 # directory and the targets for sys/*.h files conditional to the OS requiring
 # them.
-file(MAKE_DIRECTORY "sys")
+file(MAKE_DIRECTORY ${LIBC_INCLUDE_DIR}/sys)
 
 add_gen_header(
   sys_auxv
@@ -497,7 +497,7 @@ add_gen_header(
 )
 
 if(LIBC_TARGET_ARCHITECTURE_IS_GPU)
-  file(MAKE_DIRECTORY "gpu")
+  file(MAKE_DIRECTORY ${LIBC_INCLUDE_DIR}/"gpu")
 
   add_gen_header(
     gpu_rpc

``````````

</details>


https://github.com/llvm/llvm-project/pull/66589


More information about the libc-commits mailing list