[libc-commits] [libc] 2ad7a06 - [libc] Fix some warnings (#66366)

[via libc-commits]

Author: Alex Brachet
Date: 2023-09-14T08:47:21-04:00
New Revision: 2ad7a06cb1623f67fc818070ed13577cca7e131d

URL: https://github.com/llvm/llvm-project/commit/2ad7a06cb1623f67fc818070ed13577cca7e131d
DIFF: https://github.com/llvm/llvm-project/commit/2ad7a06cb1623f67fc818070ed13577cca7e131d.diff

LOG: [libc] Fix some warnings (#66366)

Some compilers will warn about dangling else and missleading lack of
parentheses.

Added: 
    

Modified: 
    libc/src/__support/CPP/limits.h
    libc/test/src/ctype/isprint_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/src/__support/CPP/limits.h b/libc/src/__support/CPP/limits.h
index e42414523a76df7..46a1172c285020c 100644
--- a/libc/src/__support/CPP/limits.h
+++ b/libc/src/__support/CPP/limits.h
@@ -17,8 +17,8 @@ namespace cpp {
 // Some older gcc distributions don't define these for 32 bit targets.
 #ifndef LLONG_MAX
 constexpr size_t LLONG_BIT_WIDTH = sizeof(long long) * 8;
-constexpr long long LLONG_MAX = ~0LL ^ (1LL << LLONG_BIT_WIDTH - 1);
-constexpr long long LLONG_MIN = 1LL << LLONG_BIT_WIDTH - 1;
+constexpr long long LLONG_MAX = ~0LL ^ (1LL << (LLONG_BIT_WIDTH - 1));
+constexpr long long LLONG_MIN = 1LL << (LLONG_BIT_WIDTH - 1);
 constexpr unsigned long long ULLONG_MAX = ~0ULL;
 #endif
 

diff  --git a/libc/test/src/ctype/isprint_test.cpp b/libc/test/src/ctype/isprint_test.cpp
index d7278fadc10fd52..08963209c1d4cb0 100644
--- a/libc/test/src/ctype/isprint_test.cpp
+++ b/libc/test/src/ctype/isprint_test.cpp
@@ -11,9 +11,10 @@
 
 TEST(LlvmLibcIsPrint, DefaultLocale) {
   for (int ch = -255; ch < 255; ++ch) {
-    if (' ' <= ch && ch <= '~') // A-Z, a-z, 0-9, punctuation, space.
+    if (' ' <= ch && ch <= '~') { // A-Z, a-z, 0-9, punctuation, space.
       EXPECT_NE(__llvm_libc::isprint(ch), 0);
-    else
+    } else {
       EXPECT_EQ(__llvm_libc::isprint(ch), 0);
+    }
   }
 }