[libc-commits] [libc] [libc] Fix some warnings (PR #66366)

[Alex Brachet via libc-commits]

https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/66366:

Some compilers will warn about dangling else and missleading lack of parentheses.

>From 3363f420df22756421ea1098eee18b3a038201bb Mon Sep 17 00:00:00 2001
From: Alex Brachet <abrachet at google.com>
Date: Wed, 13 Sep 2023 14:32:36 -0400
Subject: [PATCH] [libc] Fix some warnings

Some compilers will warn about dangling else and missleading
lack of parentheses.
---
 libc/src/__support/CPP/limits.h      | 4 ++--
 libc/test/src/ctype/isprint_test.cpp | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/libc/src/__support/CPP/limits.h b/libc/src/__support/CPP/limits.h
index e42414523a76df7..46a1172c285020c 100644
--- a/libc/src/__support/CPP/limits.h
+++ b/libc/src/__support/CPP/limits.h
@@ -17,8 +17,8 @@ namespace cpp {
 // Some older gcc distributions don't define these for 32 bit targets.
 #ifndef LLONG_MAX
 constexpr size_t LLONG_BIT_WIDTH = sizeof(long long) * 8;
-constexpr long long LLONG_MAX = ~0LL ^ (1LL << LLONG_BIT_WIDTH - 1);
-constexpr long long LLONG_MIN = 1LL << LLONG_BIT_WIDTH - 1;
+constexpr long long LLONG_MAX = ~0LL ^ (1LL << (LLONG_BIT_WIDTH - 1));
+constexpr long long LLONG_MIN = 1LL << (LLONG_BIT_WIDTH - 1);
 constexpr unsigned long long ULLONG_MAX = ~0ULL;
 #endif
 
diff --git a/libc/test/src/ctype/isprint_test.cpp b/libc/test/src/ctype/isprint_test.cpp
index d7278fadc10fd52..08963209c1d4cb0 100644
--- a/libc/test/src/ctype/isprint_test.cpp
+++ b/libc/test/src/ctype/isprint_test.cpp
@@ -11,9 +11,10 @@
 
 TEST(LlvmLibcIsPrint, DefaultLocale) {
   for (int ch = -255; ch < 255; ++ch) {
-    if (' ' <= ch && ch <= '~') // A-Z, a-z, 0-9, punctuation, space.
+    if (' ' <= ch && ch <= '~') { // A-Z, a-z, 0-9, punctuation, space.
       EXPECT_NE(__llvm_libc::isprint(ch), 0);
-    else
+    } else {
       EXPECT_EQ(__llvm_libc::isprint(ch), 0);
+    }
   }
 }