[libc-commits] [libc] [libc][NFC] Make the dummy header target under overlay build a library. (PR #66329)

Siva Chandra via libc-commits libc-commits at lists.llvm.org
Wed Sep 13 22:51:56 PDT 2023


https://github.com/sivachandra created https://github.com/llvm/llvm-project/pull/66329:

This fixes the broken overlay builders.


>From d51c233a8c371a1dc5fd7f0d5f89b42245e16cfc Mon Sep 17 00:00:00 2001
From: Siva Chandra Reddy <sivachandra at google.com>
Date: Thu, 14 Sep 2023 05:38:47 +0000
Subject: [PATCH] [libc][NFC] Make the dummy header target under overlay build
 a library.

This fixes the broken overlay builders.
---
 libc/cmake/modules/LLVMLibCHeaderRules.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libc/cmake/modules/LLVMLibCHeaderRules.cmake b/libc/cmake/modules/LLVMLibCHeaderRules.cmake
index e259a512ea760f6..1027a55946d5f8b 100644
--- a/libc/cmake/modules/LLVMLibCHeaderRules.cmake
+++ b/libc/cmake/modules/LLVMLibCHeaderRules.cmake
@@ -86,7 +86,7 @@ function(add_gen_header target_name)
   get_fq_target_name(${target_name} fq_target_name)
   if(NOT LLVM_LIBC_FULL_BUILD)
     # We don't want to use generated headers if we are doing a non-full-build.
-    add_custom_target(${fq_target_name})
+    add_library(${fq_target_name} INTERFACE)
     return()
   endif()
   if(NOT ADD_GEN_HDR_DEF_FILE)



More information about the libc-commits mailing list