[libc-commits] [libc] 089b811 - [libc][NFC][Docs] Update some GPU testing information
Joseph Huber via libc-commits
libc-commits at lists.llvm.org
Wed Sep 13 12:30:42 PDT 2023
Author: Joseph Huber
Date: 2023-09-13T14:30:30-05:00
New Revision: 089b81105acbc4892c96f9e7ff0a47c4df02da29
URL: https://github.com/llvm/llvm-project/commit/089b81105acbc4892c96f9e7ff0a47c4df02da29
DIFF: https://github.com/llvm/llvm-project/commit/089b81105acbc4892c96f9e7ff0a47c4df02da29.diff
LOG: [libc][NFC][Docs] Update some GPU testing information
Summary:
This comment is outddated and can be removed, also mention an option for
limiting parallelism during tests in the documentation.
Added:
Modified:
libc/CMakeLists.txt
libc/docs/gpu/testing.rst
Removed:
################################################################################
diff --git a/libc/CMakeLists.txt b/libc/CMakeLists.txt
index 12fff25c197e2d9..752b048cd397a23 100644
--- a/libc/CMakeLists.txt
+++ b/libc/CMakeLists.txt
@@ -288,7 +288,6 @@ endif()
# The lib and test directories are added at the very end as tests
# and libraries potentially draw from the components present in all
# of the other directories.
-# TODO: Add testing support for the libc GPU target.
add_subdirectory(lib)
if(LLVM_INCLUDE_TESTS)
add_subdirectory(test)
diff --git a/libc/docs/gpu/testing.rst b/libc/docs/gpu/testing.rst
index 6e5bed5358cd8be..d0f162694562deb 100644
--- a/libc/docs/gpu/testing.rst
+++ b/libc/docs/gpu/testing.rst
@@ -8,7 +8,7 @@ Testing the GPU libc library
.. note::
Running GPU tests with high parallelism is likely to cause spurious failures,
out of resource errors, or indefinite hangs. limiting the number of threads
- used while testing is highly recommended.
+ used while testing using ``LIBC_GPU_TEST_JOBS=<N>`` is highly recommended.
.. contents:: Table of Contents
:depth: 4
More information about the libc-commits
mailing list