[libc-commits] [PATCH] D158774: [libc] Add GPU support for `printf` and `fprintf`

Matt Arsenault via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Sep 12 04:32:18 PDT 2023


arsenm added inline comments.


================
Comment at: libc/src/stdio/gpu/parser.h:54
+      return 0;
+    else if (cur.is_string)
+      return internal::string_length(reinterpret_cast<char *>(cur.raw_value)) +
----------------
no else after return 


================
Comment at: libc/src/stdio/gpu/parser.h:64
+      return reinterpret_cast<void *>(cur.raw_value);
+    else
+      return &cur.raw_value;
----------------
no else after return 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158774/new/

https://reviews.llvm.org/D158774



More information about the libc-commits mailing list