[libc-commits] [PATCH] D158640: [libc][riscv] Added support for rv32 in setjmp and longjmp

Tue Sep 5 02:13:50 PDT 2023

asb added a comment.

In D158640#4611308 <https://reviews.llvm.org/D158640#4611308>, @aaron.ballman wrote:

> In D158640#4611291 <https://reviews.llvm.org/D158640#4611291>, @jrtc27 wrote:
>
>> You can likely get away with it then, but don't be surprised when it breaks... this will never be officially supported by the compiler
>
> I'd like to second this -- it seems pretty fragile that you need to compile this with very specific optimization flags in order for it to work, especially when there is a solution but it's prevented due to a policy of not allowing hand-written assembly files.

I was away the past couple of weeks, but this appears fragile to me as well. I've posted https://discourse.llvm.org/t/hand-written-in-assembly-in-libc-setjmp-longjmp/73249 to continue the discussion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158640/new/

https://reviews.llvm.org/D158640