[libc-commits] [PATCH] D159158: [libc] Add a JSON based config option system.

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/cmake/modules/LibcConfig.cmake:122
+      if(${optname_exists} GREATER -1)
+        # This option is not be overriden so just skip further processing.
+        continue()
----------------
sivachandra wrote:
> gchatelet wrote:
> > sivachandra wrote:
> > > gchatelet wrote:
> > > > ?
> > > Didn't understand :)
> > Sorry I should have been more explicit.
> > 
> > I can't parse `This option is not be overriden`, is this `This option is not *to* be *overridden*`?
> Oh! Fixed now.
I think there's still one `d` missing in `overriden`, should be `overridden` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159158/new/

https://reviews.llvm.org/D159158