[libc-commits] [PATCH] D159112: [libc] customizable namespace 1/4

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Have an inline question but LGTM.



================
Comment at: libc/CMakeLists.txt:57
+  set(LLVM_LIBC_NAMESPACE "${LIBC_CMAKE_NAMESPACE}")
+else()
+  set(LLVM_LIBC_NAMESPACE "__llvm_libc_${LLVM_VERSION_MAJOR}_${LLVM_VERSION_MINOR}_${LLVM_VERSION_PATCH}_${LLVM_VERSION_SUFFIX}")
----------------
May be I am missing something. Wouldn't the `FORCE` make it take the `else` path always?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159112/new/

https://reviews.llvm.org/D159112