[libc-commits] [libc] [libc][NFC] Adjust use of off_t internally (PR #68269)

Mikhail R. Gadelha via libc-commits libc-commits at lists.llvm.org
Fri Oct 6 10:43:11 PDT 2023


mikhailramalho wrote:

> I'd like to see proof that the split is correct, since it's going to come up again I think a function + tests would get us covered.

Do you mean adding more regressions to the code base?

Currently, the pread/pwrite changes are tests by `pread_pwrite_test.cpp`, while the file changes are tested by several tests already.

I tested it locally for rv32 and this patch doesn't introduce any regressions. I don't think the rv32 buildbot will test this for now, as it needs `LLVM_LIBC_FULL_BUILD=ON` but I plan to enable it soon.


https://github.com/llvm/llvm-project/pull/68269


More information about the libc-commits mailing list