[libc-commits] [libc] [libc] Change the GPU to use builtin memory functions (PR #68003)

Guillaume Chatelet via libc-commits libc-commits at lists.llvm.org
Tue Oct 3 06:48:17 PDT 2023


https://github.com/gchatelet commented:

Patch LGTM with the following comments:
 - I don't see `inline_memcmp.h` but it should be modified as well
 - As-is this will probably fail to compile as we define a config wise `-ffreestanding` that in turn triggers `-fno-builtins`. So you probably need to tweak the CMake configuration as well. Maybe we can just revert the `-ffreestanding` for the GPU mem targets? Something like `COMPILE_OPTIONS -fno-freestanding -fno-builtins -fbuiltin=memcpy` for  the GPU version of `memcpy` and so on and so forth.


https://github.com/llvm/llvm-project/pull/68003


More information about the libc-commits mailing list