[libc-commits] [libc] [libc] fix getchar_unlocked (PR #73874)

via libc-commits libc-commits at lists.llvm.org
Wed Nov 29 16:25:24 PST 2023


================
@@ -319,7 +319,7 @@ add_entrypoint_object(
 add_entrypoint_object(
   getchar_unlocked
   SRCS
-    getc_unlocked.cpp
+    getchar_unlocked.cpp
   HDRS
     ../getc_unlocked.h
----------------
michaelrj-google wrote:

probably? It's just not something I've looked into that closely. The functions that take input from stdin all have corresponding functions that take input from a provided file, so we generally just test with those. Of course, this is revealing that we really should have tests for the stdin functions, even if they're just smoke tests.

https://github.com/llvm/llvm-project/pull/73874


More information about the libc-commits mailing list