[libc-commits] [libc] [libc][FIXME] Disable math tests to make the GPU bots green (PR #71603)
via libc-commits
libc-commits at lists.llvm.org
Tue Nov 7 15:30:48 PST 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Joseph Huber (jhuber6)
<details>
<summary>Changes</summary>
Summary:
This is a quick hack to disable affected GPU math tests so the bots will
be green again.
The offending commit is d2361b204857820d18aa344b890072df8d6154dd. If
that is reverted along with this patch the tests also pass.
---
Full diff: https://github.com/llvm/llvm-project/pull/71603.diff
2 Files Affected:
- (modified) libc/test/src/math/CMakeLists.txt (+10)
- (modified) libc/test/src/math/smoke/CMakeLists.txt (+64)
``````````diff
diff --git a/libc/test/src/math/CMakeLists.txt b/libc/test/src/math/CMakeLists.txt
index 34e937b6d744b79..fcb47449748dcac 100644
--- a/libc/test/src/math/CMakeLists.txt
+++ b/libc/test/src/math/CMakeLists.txt
@@ -673,6 +673,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysign
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -687,6 +689,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysignf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -701,6 +705,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysignl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1462,6 +1468,8 @@ add_fp_unittest(
libc.src.math.fmodf
libc.src.__support.FPUtil.basic_operations
libc.src.__support.FPUtil.nearest_integer_operations
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1478,6 +1486,8 @@ add_fp_unittest(
libc.src.math.fmod
libc.src.__support.FPUtil.basic_operations
libc.src.__support.FPUtil.nearest_integer_operations
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 2645f595903a697..995dee7b0b54829 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -65,6 +65,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.fabs
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -79,6 +81,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.fabsf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -93,6 +97,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.fabsl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -107,6 +113,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.trunc
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -121,6 +129,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.truncf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -135,6 +145,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.truncl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -149,6 +161,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.ceil
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -163,6 +177,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.ceilf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -177,6 +193,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.ceill
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -191,6 +209,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.floor
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -205,6 +225,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.floorf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -219,6 +241,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.floorl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -233,6 +257,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.round
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -247,6 +273,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.roundf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -261,6 +289,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.roundl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -279,6 +309,8 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.lround
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -297,6 +329,8 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.lroundf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -315,6 +349,8 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.lroundl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -333,6 +369,8 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.llround
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -351,6 +389,8 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.llroundf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -369,6 +409,8 @@ add_fp_unittest(
libc.src.fenv.fetestexcept
libc.src.math.llroundl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -596,6 +638,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysign
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -610,6 +654,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysignf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -624,6 +670,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.copysignl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -990,6 +1038,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.sqrtf
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1002,6 +1052,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.sqrt
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1014,6 +1066,8 @@ add_fp_unittest(
libc.include.math
libc.src.math.sqrtl
libc.src.__support.FPUtil.fp_bits
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1028,6 +1082,8 @@ add_fp_unittest(
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
-O3
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1042,6 +1098,8 @@ add_fp_unittest(
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
-O3
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1056,6 +1114,8 @@ add_fp_unittest(
libc.src.__support.FPUtil.generic.sqrt
COMPILE_OPTIONS
-O3
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1347,6 +1407,8 @@ add_fp_unittest(
libc.src.math.fmodf
libc.src.__support.FPUtil.basic_operations
libc.src.__support.FPUtil.nearest_integer_operations
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
@@ -1363,6 +1425,8 @@ add_fp_unittest(
libc.src.math.fmod
libc.src.__support.FPUtil.basic_operations
libc.src.__support.FPUtil.nearest_integer_operations
+ # FIXME: Currently fails on the GPU build.
+ UNIT_TEST_ONLY
)
add_fp_unittest(
``````````
</details>
https://github.com/llvm/llvm-project/pull/71603
More information about the libc-commits
mailing list