[libc-commits] [flang] [libcxx] [libc] [compiler-rt] [llvm] [clang-tools-extra] [clang] [mlir] Make SmallVectorImpl destructor protected (PR #71439)

[Jakub Kuderski via libc-commits]

================
@@ -95,7 +95,7 @@ class SerializeToHsacoPass
   std::unique_ptr<std::vector<char>>
   serializeISA(const std::string &isa) override;
 
-  std::unique_ptr<SmallVectorImpl<char>> assembleIsa(const std::string &isa);
+  std::unique_ptr<SmallVector<char, 16>> assembleIsa(const std::string &isa);
----------------
kuhar wrote:

IMO this should either return `SmallVector<char>` (without an exact size) or take `SmallVectorImpl<char> &` as the second function argument

https://github.com/llvm/llvm-project/pull/71439