[libc-commits] [PATCH] D151282: [libc] Add initial support for 'puts' and 'fputs' to the GPU

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue May 30 15:54:12 PDT 2023


jhuber6 added inline comments.


================
Comment at: libc/src/__support/File/file.cpp:345
 
-  if (buffer != nullptr && size == 0)
+  if ((buffer != nullptr && size == 0) || ENABLE_BUFFER)
     return EINVAL;
----------------
lntue wrote:
> Shouldn't this be `!ENABLE_BUFFER`?
You're right, I'll fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151282/new/

https://reviews.llvm.org/D151282



More information about the libc-commits mailing list