[libc-commits] [PATCH] D151735: [libc] Implement basic `malloc` and `free` support on the GPU

[Joseph Huber via Phabricator via libc-commits]

jhuber6 marked 2 inline comments as done.
jhuber6 added inline comments.


================
Comment at: libc/src/__support/RPC/rpc.h:38
   EXIT = 2,
-  TEST_INCREMENT = 3,
-  TEST_INTERFACE = 4,
-  TEST_STREAM = 5,
+  MALLOC = 3,
+  FREE = 4,
----------------
jplehr wrote:
> Out of curiosity: Why not append these values to the existing ones instead?
Tentatively planned, but the goal is to later provide this more as a library interface. Users of the library can then register their own custom opcodes, probably reserving anything that has a MSB of `1` to be a custom opcode, the rest we can reserve for internal `libc` use. So the goal is to move the test ones somewhere else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151735/new/

https://reviews.llvm.org/D151735