[libc-commits] [PATCH] D151494: [libc] Fix compilation issues in memory_check_utils.h

Roland McGrath via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu May 25 13:59:13 PDT 2023


mcgrathr created this revision.
mcgrathr added reviewers: abrachet, sivachandra.
Herald added subscribers: libc-commits, tschuett.
Herald added projects: libc-project, All.
mcgrathr requested review of this revision.

Strict warnings require explicit static_cast to counteract
default widening of types narrower than int.

Functions in header files should have vague linkage (inline
keyword), not internal linkage (static) or external linkage
(no inline keyword) even for template functions.  Note these
don't use the LIBC_INLINE macro since this is only for test code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151494

Files:
  libc/test/src/string/memory_utils/memory_check_utils.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151494.525785.patch
Type: text/x-patch
Size: 3968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230525/f6292576/attachment.bin>


More information about the libc-commits mailing list