[libc-commits] [PATCH] D151129: [libc] Make ErrnoSetterMatcher ignore matching errno on GPU.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D151129#4373077 <https://reviews.llvm.org/D151129#4373077>, @jhuber6 wrote:

> In D151129#4373075 <https://reviews.llvm.org/D151129#4373075>, @sivachandra wrote:
>
>> I think all of those errors have a single root cause that `EILSEQ` was missing from the list of generic error numbers. I have added it now. Can you give it another try?
>
> Yes, I think we just need to make the `thread_local` error buffer a regular integer on platforms without `errno`. (Same reason we can't support it in the first place).

Few things:

1. This patch is likely titled incorrectly titled because I uploaded when I wanted to quickly show how we can ignore testing for `errno`. I totally happy to remove that part (re-title this patch anyway).
2. If you want to consider GPU to be a platform without `errno`, that is up to you. But, This question goes beyond `errno`. Is the GPU platform in general a platform without thread local variable support? If yes, we need to say that somewhere and give guidance on how to detect C library function errors.
3. Is the libc project groups and patches the right forum to discuss/decide about GPU `errno`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151129/new/

https://reviews.llvm.org/D151129