[libc-commits] [PATCH] D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions

Wed May 24 10:05:54 PDT 2023

sivachandra added a comment.

In D148797#4299288 <https://reviews.llvm.org/D148797#4299288>, @sivachandra wrote:

> This change LGTM in general. But, I would like to have instructions on how to test this before I accept it. Couple of reasons:
>
> 1. We want to have an estimate for the public CI.
> 2. Since this patch is unifying riscv64 and riscv32, I want to see how much of riscv32 actually works. Things like, if a riscv64 change does not work for riscv32, would we require that the contributor/patch author block on riscv32 changes?

I would like to see answers to the above questions before we can take this patch forward.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148797/new/

https://reviews.llvm.org/D148797