[libc-commits] [PATCH] D151336: [libc] simplify test for getrandom

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed May 24 07:43:27 PDT 2023


gchatelet added inline comments.


================
Comment at: libc/test/src/sys/random/linux/getrandom_test.cpp:21
+              __llvm_libc::testing::ErrnoSetterMatcher::Fails(EINVAL));
   libc_errno = 0;
 }
----------------
lntue wrote:
> I think these are redundant, `ErrnoSetterMatcher` does reset `libc_errno` to 0 after matching.
Sounds good, removing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151336/new/

https://reviews.llvm.org/D151336



More information about the libc-commits mailing list