[libc-commits] [PATCH] D150131: [libc][math] Implement double precision log function correctly rounded to all rounding modes.

[Paul Zimmermann via Phabricator via libc-commits]

zimmermann6 requested changes to this revision.
zimmermann6 added a comment.
This revision now requires changes to proceed.

I get failures when I try to apply this patch to head (revision 7489301 <https://reviews.llvm.org/rG7489301c03c5406a7e54e108df1c5a712b00ae90>):

  patching file libc/config/darwin/arm/entrypoints.txt
  patching file libc/config/linux/aarch64/entrypoints.txt
  patching file libc/config/linux/x86_64/entrypoints.txt
  patching file libc/config/windows/entrypoints.txt
  patching file libc/spec/stdc.td
  patching file libc/src/math/CMakeLists.txt
  patching file libc/src/math/generic/CMakeLists.txt
  Hunk #1 succeeded at 784 with fuzz 2 (offset 16 lines).
  Hunk #2 FAILED at 785.
  Hunk #3 succeeded at 846 (offset -3 lines).
  1 out of 3 hunks FAILED -- saving rejects to file libc/src/math/generic/CMakeLists.txt.rej
  patching file libc/src/math/generic/common_constants.h
  Hunk #1 FAILED at 39.
  1 out of 1 hunk FAILED -- saving rejects to file libc/src/math/generic/common_constants.h.rej
  patching file libc/src/math/generic/common_constants.cpp
  Hunk #1 succeeded at 196 with fuzz 2 (offset -169 lines).
  patching file libc/src/math/generic/log.cpp
  patching file libc/src/math/generic/log10.cpp
  Hunk #1 FAILED at 17.
  Hunk #2 FAILED at 41.
  Hunk #3 FAILED at 785.
  Hunk #4 FAILED at 944.
  4 out of 4 hunks FAILED -- saving rejects to file libc/src/math/generic/log10.cpp.rej
  patching file libc/src/math/generic/log_range_reduction.h
  patching file libc/src/math/log.h
  patching file libc/test/src/math/CMakeLists.txt
  patching file libc/test/src/math/log_test.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150131/new/

https://reviews.llvm.org/D150131