[libc-commits] [PATCH] D151097: [libc] Display unit test runtime for hosted environments

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon May 22 22:04:26 PDT 2023


sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/UnitTest/LibcTest.cpp:179
     auto Result = Ctx.status();
+    const auto duration = clock() - start_time;
+    const auto elapsed_ms =
----------------
`clock()` return value wraps around after every N minutes. Should we check if `clock()` return value here is greater than `start_time`? If not, report "Unknown - try rerunning"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151097/new/

https://reviews.llvm.org/D151097



More information about the libc-commits mailing list