[libc-commits] [PATCH] D151155: [libc] Add an option to make `libc` only build the `libc-hdrgen` tool

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/CMakeLists.txt:32
+if("libc" IN_LIST LLVM_ENABLE_RUNTIMES AND NOT LLVM_RUNTIMES_BUILD OR 
+   LIBC_HDRGEN_ONLY)
   # When libc is build as part of the runtimes/bootstrap build's CMake run, we
----------------
michaelrj wrote:
> nit: having some parentheses here would help clarify what the actual condition is.
This is OK but add an option which is `OFF` by default. Its not clear to me that this how we have to the libc build. We are stretching the limits of what is formally supported because of what happens to work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151155/new/

https://reviews.llvm.org/D151155