[libc-commits] [PATCH] D149594: [libc] Add explicit constructor calls to fix compilation when using UInt<T>

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/__support/UInt.h:83
+    __uint128_t tmp = val[0];
+    if constexpr (Bits == 128)
+      tmp += (__uint128_t(val[1]) << 64);
----------------
`Bits >= 128`


================
Comment at: libc/src/__support/UInt.h:480
 
+  constexpr UInt<Bits> operator/=(const UInt<Bits> &other) {
+    *this = *this / other;
----------------
Should the return type be `UInt<Bits>&`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149594/new/

https://reviews.llvm.org/D149594