[libc-commits] [PATCH] D150399: [libc] add options to printf decimal floats

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/__support/float_to_string.h:635
+    // ------------------------------ TABLE MODE -------------------------------
+    const uint32_t shift_amount =
+        POW10_ADDITIONAL_BITS_TABLE + pos_exp - exponent;
----------------
lntue wrote:
> The definitions of `shift_amount` are the same in all branches?
not quite, the table mode `shift_amount` uses `POW10_ADDITIONAL_BITS_TABLE` instead of `POW10_ADDITIONAL_BITS_CALC`. I'm going to rename those variables to avoid this confusion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150399/new/

https://reviews.llvm.org/D150399