[libc-commits] [PATCH] D150905: [libc] Use MPFR for strtofloat fuzzing

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/src/__support/str_to_float.h:276
+  // Handle overflow in the middle
+  approx_upper += (approx_middle < approx_middle_a) ? UInt128(1) << 64 : 0;
 
----------------
lntue wrote:
> Does replacing `UInt128(1) << 64` with `UInt128({0, 1})` work?
this `UInt128` isn't necessarily the `UInt` class, it's a raw `uint128_t` when that's available, so we can't do any sort of constructor on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150905/new/

https://reviews.llvm.org/D150905