[libc-commits] [PATCH] D150513: [libc] Simplify RPC send and recv callback interface

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu May 18 14:44:25 PDT 2023


michaelrj added a comment.

LGTM



================
Comment at: libc/src/__support/CPP/type_traits.h:60
 
+template <typename T> struct remove_pointer : type_identity<T> {};
+template <typename T> struct remove_pointer<T *> : type_identity<T> {};
----------------
nit: I think these should go right after `is_pointer`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150513/new/

https://reviews.llvm.org/D150513



More information about the libc-commits mailing list