[libc-commits] [PATCH] D150906: [libc] Add a str() method to FPBits which returns a string representation.

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

I'll test this patch on aarch64 to check the float128 support



================
Comment at: libc/test/src/__support/FPUtil/fpbits_test.cpp:145
+      "(S: 0, E: 0x0000, I: 0, M: 0x00000000000000000000000000000000)");
+#else
+  EXPECT_STREQ(zero.str().c_str(),
----------------
sivachandra wrote:
> michaelrj wrote:
> > there are three types of long double we support, 80 bit, 128 bit, and 64 bit. These tests won't work on 64 bit long double systems.
> We skip doing long double checks completely if `long double` == `double` on line 125.
ah, that makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150906/new/

https://reviews.llvm.org/D150906