[libc-commits] [PATCH] D150898: [libc] Disable newly added test from running on NVPTX

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu May 18 12:04:39 PDT 2023


jhuber6 created this revision.
Herald added subscribers: libc-commits, mattd, gchakrabarti, asavonic, ecnelises, tschuett.
Herald added projects: libc-project, All.
jhuber6 requested review of this revision.

A recent patch enabled this test which turns out to segfault on the
NVPTX architecture. We disable it for now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150898

Files:
  libc/test/src/__support/CMakeLists.txt


Index: libc/test/src/__support/CMakeLists.txt
===================================================================
--- libc/test/src/__support/CMakeLists.txt
+++ libc/test/src/__support/CMakeLists.txt
@@ -91,6 +91,8 @@
     libc.src.__support.fixedvector
 )
 
+# This test fails with a segmentation fault on NVPTX.
+if(NOT LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX)
 add_libc_test(
   char_vector_test
   # This test relies on 'realloc' which is not implemented for hermetic tests.
@@ -102,6 +104,7 @@
   DEPENDS
     libc.src.__support.char_vector
 )
+endif()
 
 add_executable(
   libc_str_to_float_comparison_test


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150898.523494.patch
Type: text/x-patch
Size: 612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230518/539f637c/attachment.bin>


More information about the libc-commits mailing list