[libc-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

[Mark de Wever via Phabricator via libc-commits]

Mordante added a comment.

In D144509#4349921 <https://reviews.llvm.org/D144509#4349921>, @thakis wrote:

> Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 <https://reviews.llvm.org/rGd763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6> for now.
>
> Sorry this is such a pain to land :(
>
> (See also discussion over in D150688 <https://reviews.llvm.org/D150688>)

I'm not happy that the patch needs to be reverted again.

It has taken me a lot of time to contact all buildbots maintainers to get all buildbots updated to the minimal CMake requirement.
Now that they are updated it turned out that one of the two last updated bots has an issue with this patch and that has been fixed. But now it seems to break Chromium. I don't have access to Windows so I don't know how I can test patches.

Do you have a suggestion how we can move this patch forward?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509