[libc-commits] [PATCH] D150678: [libc][test] Improve memory check reporting
Clement Courbet via Phabricator via libc-commits
libc-commits at lists.llvm.org
Tue May 16 23:52:21 PDT 2023
courbet added inline comments.
================
Comment at: libc/test/src/string/memcmp_test.cpp:54
auto span2 = Buffer2.span().subspan(0, size);
- const bool OK = CheckMemcmp<Impl>(span1, span2, size);
- if (!OK)
- testing::tlog << "Failed at size=" << size << '\n';
- ASSERT_TRUE(OK);
+ ASSERT_TRUE(CheckMemcmp<Impl>(span1, span2, size));
}
----------------
`ASSERT_TRUE(CheckMemcmp<Impl>(span1, span2, size)) << "size=" << size;` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150678/new/
https://reviews.llvm.org/D150678
More information about the libc-commits
mailing list