[libc-commits] [PATCH] D150576: [libc][NFC] Clean up the memory buffer handling for RPC

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield requested changes to this revision.
JonChesterfield added a comment.
This revision now requires changes to proceed.

Size is shorter than the existing names but more likely to be conflated with the array length or number of ports. How about inbox_bytes or similar?



================
Comment at: libc/src/__support/RPC/rpc.h:287
+  LIBC_INLINE static uint64_t outbox_offset(uint64_t port_count, bool invert) {
+    return invert ? 0 : mailbox_size(port_count);
   }
----------------
Use the template parameter directly please. Memory layout is a compile time property, routing it through a function parameter obfuscates that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150576/new/

https://reviews.llvm.org/D150576