[libc-commits] [PATCH] D150362: [libc][obvious] Fix undefined variable after name change

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu May 11 07:00:21 PDT 2023


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG30093d6be249: [libc][obvious] Fix undefined variable after name change (authored by jhuber6).

Changed prior to commit:
  https://reviews.llvm.org/D150362?vs=521292&id=521297#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150362/new/

https://reviews.llvm.org/D150362

Files:
  libc/startup/gpu/amdgpu/start.cpp
  libc/startup/gpu/nvptx/start.cpp
  libc/utils/gpu/loader/amdgpu/Loader.cpp
  libc/utils/gpu/loader/nvptx/Loader.cpp


Index: libc/utils/gpu/loader/nvptx/Loader.cpp
===================================================================
--- libc/utils/gpu/loader/nvptx/Loader.cpp
+++ libc/utils/gpu/loader/nvptx/Loader.cpp
@@ -246,7 +246,7 @@
   if (CUresult err = cuMemsetD32(dev_ret, 0, 1))
     handle_error(err);
 
-  uint64_t port_size = __llvm_libc::rpc::default_port_count;
+  uint64_t port_size = __llvm_libc::rpc::DEFAULT_PORT_COUNT;
   uint32_t warp_size = 32;
 
   uint64_t rpc_shared_buffer_size =
Index: libc/utils/gpu/loader/amdgpu/Loader.cpp
===================================================================
--- libc/utils/gpu/loader/amdgpu/Loader.cpp
+++ libc/utils/gpu/loader/amdgpu/Loader.cpp
@@ -330,7 +330,7 @@
   hsa_amd_memory_fill(dev_ret, 0, sizeof(int));
 
   // Allocate finegrained memory for the RPC server and client to share.
-  uint64_t port_size = __llvm_libc::rpc::default_port_count;
+  uint64_t port_size = __llvm_libc::rpc::DEFAULT_PORT_COUNT;
   uint32_t wavefront_size = 0;
   if (hsa_status_t err = hsa_agent_get_info(
           dev_agent, HSA_AGENT_INFO_WAVEFRONT_SIZE, &wavefront_size))
Index: libc/startup/gpu/nvptx/start.cpp
===================================================================
--- libc/startup/gpu/nvptx/start.cpp
+++ libc/startup/gpu/nvptx/start.cpp
@@ -45,7 +45,7 @@
 _begin(int argc, char **argv, char **env, void *rpc_shared_buffer) {
   // We need to set up the RPC client first in case any of the constructors
   // require it.
-  __llvm_libc::rpc::client.reset(__llvm_libc::rpc::default_port_count,
+  __llvm_libc::rpc::client.reset(__llvm_libc::rpc::DEFAULT_PORT_COUNT,
                                  __llvm_libc::gpu::get_lane_size(),
                                  rpc_shared_buffer);
 
Index: libc/startup/gpu/amdgpu/start.cpp
===================================================================
--- libc/startup/gpu/amdgpu/start.cpp
+++ libc/startup/gpu/amdgpu/start.cpp
@@ -41,7 +41,7 @@
 _begin(int argc, char **argv, char **env, void *rpc_shared_buffer) {
   // We need to set up the RPC client first in case any of the constructors
   // require it.
-  __llvm_libc::rpc::client.reset(__llvm_libc::rpc::default_port_count,
+  __llvm_libc::rpc::client.reset(__llvm_libc::rpc::DEFAULT_PORT_COUNT,
                                  __llvm_libc::gpu::get_lane_size(),
                                  rpc_shared_buffer);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150362.521297.patch
Type: text/x-patch
Size: 2379 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230511/66b5beb0/attachment.bin>


More information about the libc-commits mailing list