[libc-commits] [PATCH] D150309: [libc][rpc] Allocate locks array within process

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield planned changes to this revision.
JonChesterfield added inline comments.


================
Comment at: libc/src/__support/RPC/rpc.h:107
 
+  enum { maximum_port_count = 128 };
+
----------------
jhuber6 wrote:
> JonChesterfield wrote:
> > Number doesn't matter hugely at this point, have gone with deliberately != default_port_count.
> What's the point of keeping both around?
I'm expecting the number of ports to be chosen at runtime based on the GPU and the number of locks to be a fixed worst case thing using a couple of kb of device memory 


================
Comment at: libc/utils/gpu/loader/amdgpu/Loader.cpp:362
   // Initialize the RPC server's buffer for host-device communication.
-  server.reset(port_size, wavefront_size, &lock, server_inbox, server_outbox,
-               buffer);
----------------
jhuber6 wrote:
> Needs the same in the nvptx loader.
Ah yes, will fix. Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150309/new/

https://reviews.llvm.org/D150309