[libc-commits] [PATCH] D148717: [libc] Improve memcmp latency and codegen

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/string/memory_utils/bcmp_implementations.h:38
 #if defined(LIBC_TARGET_ARCH_IS_X86)
+#if defined(__SSE4_1__)
 [[maybe_unused]] LIBC_INLINE BcmpReturnType
----------------
Currently we only check for `SSE4.2` in our CMake build https://github.com/llvm/llvm-project/blob/main/libc/cmake/modules/LLVMLibCCheckCpuFeatures.cmake#L9

Do you want to change or add `SSE4.1` to the list instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148717/new/

https://reviews.llvm.org/D148717