[libc-commits] [PATCH] D150202: [libc] Add optimized memcpy for RISCV 64

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/string/memory_utils/memcpy_implementations.h:36
+[[maybe_unused]] LIBC_INLINE void
+inline_memcpy_aligned_access_32bit(Ptr __restrict dst, CPtr __restrict src,
+                                   size_t count) {
----------------
Looks like this 32-bit flavor is unused? Would it make sense to add `#elif defined(LIBC_TARGET_ARCH_IS_RISCV32)` and add it there?


================
Comment at: libc/src/string/memory_utils/utils.h:101
 #else
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
----------------
Can you add a comment as to why this is required?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150202/new/

https://reviews.llvm.org/D150202