[libc-commits] [PATCH] D149598: [libc] Support concurrent RPC port access on the GPU

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

OK, much easier to parse than the earlier versions. Thanks! There's some cleanup to do post commit I think - in particular the try_open methods are messy and really similar, and it's probably worth having the inbox/outbox/locks pointers private to process.



================
Comment at: libc/src/__support/RPC/rpc.h:105
 
+  uint64_t port_size;
   uint32_t lane_size;
----------------
port_count? - its how many ports are allocated, not how big a port is


================
Comment at: libc/src/__support/RPC/rpc.h:158
   /// Invokes a function accross every active buffer across the total lane size.
   LIBC_INLINE void invoke_rpc(cpp::function<void(Buffer *)> fn,
+                              Packet &packet) {
----------------
I don't see a remaining use of *this, could be a free function (or at least static)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149598/new/

https://reviews.llvm.org/D149598